POST AUDIT CONCLUSION
Fixing the Findings
| Sl. No. | Name | Status |
|---|---|---|
| M-01 | Chainlink Sequencer Uptime Check Not Implemented Properly | Fixed |
| M-02 | Unsafe ERC20 Transfer Function Usage | Fixed |
| M-03 | Use call instead of Transfer for address payable | Fixed |
| M-04 | The owner is a single point of failure and a centralization risk | Acknowledged |
| M-05 | Non-Upgradable OpenZeppelin Contracts Used in Upgradeable Contracts | Fixed |
| M-06 | Missing Access control in emergencyClose() function | Acknowledged |
| L-01 | No logic is implemented to handle profit in rollover function | Acknowledged |
| L-02 | Natspec is missing | Acknowledged |
| L-03 | Missing Zero-Address Check in setGmxObserver() Function | Fixed |
| L-04 | NO error or revert in claim function if claim | Fixed |
| L-05 | Avoid the use Of Floating Pragma | Acknowledged |
| L-06 | Consider implementing two-step procedure for updating protocol addresses | Acknowledged |
| L-07 | Unused receive() function will lock Ether in contract | Acknowledged |
| L-08 | Use Ownable2StepUpgradable rather than OwnableReadable | Fixed |
| 1-01 | Removal Of Commented-Out Code for Better Code Quality | Acknowledged |
| 1-02 | Open TODOs | Acknowledged |
| 1-03 | Variable names don't follow the Solidity style guide | Acknowledged |
| 1-04 | Using unnamed mappings | Acknowledged |
| 1-05 | Consider adding emergency-stop functionality | Acknowledged |
| 1-06 | Imports could be organized more systematically | Acknowledged |
| 1-07 | Event is not properly indexed | Acknowledged |
| 1-08 | Typos | Fixed |
| G-01 | Explicitly initializing variables with their default values wastes gas | Fixed |
| G-02 | Use assembly to check for address(0) | Acknowledged |
| G-03 | Caching the array length outside a loop | Fixed |
| G-04 | Redundant zero-address check in the removeTrader() function | Fixed |